Make use of standard RecyclerView Holder optimizations. #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtstern
reviewed
Nov 28, 2016
| left_arrow.setVisibility(View.GONE); | ||
| right_arrow.setVisibility(View.VISIBLE); | ||
| messageContainer.setGravity(Gravity.END); | ||
| color = ContextCompat.getColor(itemView.getContext(), R.color.material_green_300); |
There was a problem hiding this comment.
While we're feeling cache-y, might as well cache these two colors on ViewHolder creation (or even at a higher level)
There was a problem hiding this comment.
Considered that, but those could actually theoretically change when the configuration changes as well. If we want to assume they don't, then they're cachable as well.
There was a problem hiding this comment.
Since this is a very simple sample app let's assume they don't.
|
LGTM, made one comment for an additional improvement while I have you here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An important optimization that RecyclerView offers is the ability to cache the results of (potentially expensive) calls to findViewById() inside a ViewHolder so that they don't have to be repeated every time data is bound to a recycled view.