-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Differentiate between user cancellation and actual errors #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
358e965
Refactor result codes
SUPERCILEX f3d9d72
Move ResultCodes.java to base package
SUPERCILEX ae29a5c
Differentiate various failures from user cancel events
SUPERCILEX e39aaa1
Add isNewUser to IdpResponse.java
SUPERCILEX 093967d
Cleanup
SUPERCILEX ba4a1a4
Bug fixes and sample updates
SUPERCILEX 197463e
Remove isNewEmailUser
SUPERCILEX da54dee
Add backwards compatibility
SUPERCILEX 0837a6a
Cleanup
SUPERCILEX a2dc35e
Address review comments
SUPERCILEX a541fd8
Update README.md
SUPERCILEX 761e83a
Cleanup
SUPERCILEX 7482754
Refactor IdpResponse.java intents
SUPERCILEX 3fee673
Fix README
SUPERCILEX 19174f1
Fix README and extract ErrorCodes.java
SUPERCILEX d56058b
Cleanup handling sign in response
SUPERCILEX e36c35d
Comment tweaks
SUPERCILEX b3c4892
Remove unnecessary null checks
SUPERCILEX 22dfd43
Merge remote-tracking branch 'firebase/master' into error-codes
SUPERCILEX d8d4f41
Merge remote-tracking branch 'firebase/master' into error-codes
SUPERCILEX c497160
Merge remote-tracking branch 'firebase/version-1.1.0-dev' into error-…
SUPERCILEX b49e43f
Fix merge mistakes
SUPERCILEX File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since
fromResultIntentis annotated as@Nullable, I think this was the original intention.