Fb mem leak + remove BuildConfig.DEBUG #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
# Conflicts: # auth/src/main/java/com/firebase/ui/auth/provider/FacebookProvider.java
…-leak # Conflicts: # auth/src/main/java/com/firebase/ui/auth/provider/FacebookProvider.java
SUPERCILEX
commented
Dec 6, 2016
| // a HashMap in the CallbackManager instance, sCallbackManager. | ||
| // Because FacebookProvider which contains an instance of an activity, mCallbackObject, | ||
| // is contained in sCallbackManager, that activity will not be garbage collected. | ||
| // Thus, we have leaked an Activity. |
There was a problem hiding this comment.
Do we want to keep this explanation? It's a bit lengthy and could probably be replaced with // Fixes activity leaks.
Here is the Facebook code in question:
CallbackManager.Factory.create()
public static CallbackManager create() {
return new CallbackManagerImpl();
}loginManager.registerCallback(sCallbackManager, ***this***);->
/**
* Registers a login callback to the given callback manager.
* @param callbackManager The callback manager that will encapsulate the callback.
* @param callback The login callback that will be called on login completion.
*/
public void registerCallback(
final CallbackManager callbackManager,
final FacebookCallback<LoginResult> callback) {
if (!(callbackManager instanceof CallbackManagerImpl)) {
throw new FacebookException("Unexpected CallbackManager, " +
"please use the provided Factory.");
}
((CallbackManagerImpl) callbackManager).registerCallback( // sCallbackManager is storing callback into itself
CallbackManagerImpl.RequestCodeOffset.Login.toRequestCode(),
new CallbackManagerImpl.Callback() {
@Override
public boolean onActivityResult(int resultCode, Intent data) {
return LoginManager.this.onActivityResult(
resultCode,
data,
***callback***);
}
}
);
}->
private Map<Integer, CallbackManagerImpl.Callback> callbacks = new HashMap<>();
public void registerCallback(int requestCode, Callback callback) {
Validate.notNull(callback, "callback");
callbacks.put(requestCode, ***callback***); // Callback is now in callbacks HashMap
}
There was a problem hiding this comment.
Thanks for the super-detailed investigation. I am fine with the long comment, it makes people more scared to undo your fix.
samtstern
approved these changes
Dec 7, 2016
| } else { | ||
| try { | ||
| String email = object.getString("email"); | ||
| mCallbackObject.onSuccess(createIDPResponse(loginResult, email)); | ||
| FacebookProvider.this.onSuccess(email, loginResult); |
There was a problem hiding this comment.
Any reason this branch has FacebookProvider.this but the failure branch does not?
| // a HashMap in the CallbackManager instance, sCallbackManager. | ||
| // Because FacebookProvider which contains an instance of an activity, mCallbackObject, | ||
| // is contained in sCallbackManager, that activity will not be garbage collected. | ||
| // Thus, we have leaked an Activity. |
There was a problem hiding this comment.
Thanks for the super-detailed investigation. I am fine with the long comment, it makes people more scared to undo your fix.
Signed-off-by: Alex Saveau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes! This is the last leak I've encountered so once this gets merged, FirebaseUI will finally be leak free!
The leak will occur when the
startLogin()method is called inFacebookProvider: