Use vectors instead of pngs! #459
Conversation
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
| <vector | ||
| xmlns:android="http://schemas.android.com/apk/res/android" | ||
| android:width="22dp" | ||
| android:height="22dp" |
There was a problem hiding this comment.
For some weird reason, the Facebook icon looked too big at 24dp.
|
Looks nice! Just curious, where did you get the vector assets? |
|
@samtstern Oh crud, I forgot about copyright stuff! I got the email asset from Android Studio's material icon asset generator and I got each provider's icon from their respective wikipedia pages:
I then imported all those into Android Studio. 👮 🚓 I'm hoping this isn't copyright infringement! 😄 |
|
We should do something better than "hoping" for that. The links to the
original source are a good start for doing so. And of course the same
concern on trademark status applies to the bitmaps these are replacing.
Good work btw!
…On Fri, Dec 16, 2016 at 1:32 PM Alex Saveau ***@***.***> wrote:
@samtstern <https://github.com/samtstern> Oh crud, I forgot about
copyright stuff!
I got the email asset from Android Studio's material icon asset generator
and I got each provider's icon from their respective wikipedia pages:
- Google: https://en.wikipedia.org/wiki/File:Google_%22G%22_Logo.svg
- Facebook: https://commons.wikimedia.org/wiki/File:F_icon.svg
- Twitter:
https://en.wikipedia.org/wiki/File:Twitter_bird_logo_2012.svg
I then imported all those into Android Studio.
👮 🚓 I'm hoping this isn't copyright infringement! 😄
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#459 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA3w3zyYDU9K8mdnnu2EklnsghUFVIYKks5rIwNXgaJpZM4LOxK6>
.
|
|
@puf I don't know anything about legal stuff, do you know how we can check the copyright? I kind of assumed that anything from wikipedia could be used, but maybe I'm wrong. |
|
The page links you provided have a license for each of the files. Also be
sure to check your CLA. That's unfortunately as close to legal advice as I
can get.
…On Sat, Dec 17, 2016 at 11:05 AM Alex Saveau ***@***.***> wrote:
@puf <https://github.com/puf> I don't know anything about legal stuff, do
you know how we can check the copyright? I kind of assumed that anything
from wikipedia could be used, but maybe I'm wrong.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#459 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA3w32BEP8lnwo3pEj1kFmUWxexW6TDXks5rJDJ7gaJpZM4LOxK6>
.
|
|
@puf Thanks! I didn't noticed the license info at the bottom. Since I don't want to be sued, I found the logo guidelines and I believe I am allowed to provide those logos. The CLA I signed says the following:
To "include complete details" here are the guidelines I found for each provider: Facebook:
Thus, permission is not required for use online. There are extra guidelines for the "f" logo, but we're all in the green: https://facebookbrand.com/wp-content/uploads/2016/08/facebook_brandassetsguide.pdf. Twitter:
Since we are following the guidelines and the ToS, we are allowed to use their logo. More info here: Google:We're not violating the guidelines (https://developers.google.com/identity/branding-guidelines), so we can use the "g". |
|
Thanks for looking into this @SUPERCILEX.
…On Sat, Dec 17, 2016 at 11:52 AM Alex Saveau ***@***.***> wrote:
@puf <https://github.com/puf> Thanks! I didn't noticed the license info
at the bottom. Since I don't want to be sued, I found the logo guidelines
and I believe I am allowed to provide those logos.
The CLA I signed says the following:
You represent that each of Your Contributions is Your original creation
(see section 7 for submissions on behalf of others). *You represent that
Your Contribution submissions include complete details of any third-party
license or other restriction* (including, but not limited to, related
patents and trademarks) of which you are personally aware and which are
associated with any part of Your Contributions.
To "include complete details" here are the guidelines I found for each
provider:
Facebook:
*Do I need to request permission for each use of the Facebook brand
assets?*
Please follow the general rules for using the Facebook brand, along with
the rules for the specific asset you want to use. *Permission is required
if you want to use Facebook brand assets on TV or Film.*
Thus, permission is not required for use online. There are extra
guidelines for the "f" logo, but we're all in the green:
https://facebookbrand.com/wp-content/uploads/2016/08/facebook_brandassetsguide.pdf
.
Twitter:
By using the Twitter trademarks in these Brand Guidelines, you agree to
follow these Twitter Trademark Guidelines (the “Guidelines”) as well as our
Terms of Service and all other Twitter rules and policies.
Since we are following the guidelines and the ToS, we are allowed to use
their logo. More info here:
https://cdn.cms-twdigitalassets.com/content/dam/brand-twitter/asset-download-zip-files/Twitter_Brand_Guidelines.pdf
Google:
We're not violating the guidelines (
https://developers.google.com/identity/branding-guidelines), so we can
use the "g".
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#459 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA3w3yDQCUGncpfm1mWcW1pbR-UWdYYwks5rJD1igaJpZM4LOxK6>
.
|
|
Thanks for checking the copyright stuff! Can you confirm this works on API < 21? I normally use |
|
@samtstern I couldn't get an api 16 emulator with the latest play services, but I don't think that matters anyway since all the vector/material stuff was introduced in api 21. So anyway, it's working fine on api 19: |
|
👍 API 19 is good enough for me! |
|
Awesome! |
It looks much better now IMO. 🎉
Old:
New: