Puf kill switches #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets rid of most of the switch-case and repeated if-then-else constructs.
And move the need for google-services.json upward, to make it more prominent.
Firebase's JWT is still stored until it expires, but the Google token isn't
The name made no sense after we added PASSWORD to it.
This way we can invoke it from a loop in FirebaseLoginDialog. All existing implementations are now (implicit) overrides of the empty method in the base class.
This removes the need for google-services.json
…without position parameter) Fixes #9
There was a question about it here: #11.
The position parameter is no longer optional, so update the docs to always have it. Screenshots are not updated, so may still use the old signature.
This ensures we only need the Google auth binding in the build.gradle, when we are using Google auth.
| import java.lang.reflect.InvocationTargetException; | ||
|
|
||
| public enum AuthProviderType { | ||
| GOOGLE ("google", "com.firebase.ui.auth.google.GoogleAuthProvider", R.id.google_button), |
There was a problem hiding this comment.
Can we not do just "google.GoogleAuthProvider" and assume the "com.firebase.ui.auth" in the constructor? I feel like that might read better
|
Overall lgtm - thanks for cleaning up a bit of my mess :) |
…droid into puf-kill-switches
…droid into puf-kill-switches
…droid into puf-kill-switches
abeisgoat
force-pushed
the
puf-kill-switches
branch
from
a7a54b0 to
5ceaba2
Compare
abeisgoat
force-pushed
the
puf-kill-switches
branch
from
5ceaba2 to
544fc98
Compare
abeisgoat
force-pushed
the
puf-kill-switches
branch
from
705c080 to
5e96d68
Compare
abeisgoat
added a commit
that referenced
this pull request
Jan 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20. But
also changes #9 to
needing to override both
populdateView()andparseSnapshot().