Remove unnecessary theme attributes in AndroidManifest.xml #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I590bf01d6af9583324ad2d9b85cb15100db8f85c
Change-Id: Id72fe795cbab250d832dec511af3e27a8cf351e5
Signed-off-by: Alex Saveau <[email protected]>
|
I just merged #495, so I'll review this once Github gets the real diff figured out. |
|
SGTM, I'll merge in a bit. |
|
@samtstern merged! |
|
The default theme is used here if people don't set one: https://github.com/firebase/FirebaseUI-Android/blob/version-1.1.0-dev/auth/src/main/java/com/firebase/ui/auth/AuthUI.java#L516. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samtstern I think the reason we were originally confused is because we have theme attributes in the manifest. However, these aren't used so they shouldn't be there to make it clearer that we use
configureTheme.Note: this change includes #495 to minimize merge conflicts so that should be merged first.