Add a DemoApplication and RecyclerViewDemoActivity as sample #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
| @@ -90,8 +91,15 @@ | |||
| </content> | |||
| <orderEntry type="jdk" jdkName="Android API 22 Platform" jdkType="Android SDK" /> | |||
| <orderEntry type="sourceFolder" forTests="false" /> | |||
| <orderEntry type="library" exported="" name="support-v4-22.2.0" level="project" /> | |||
| <orderEntry type="library" exported="" name="support-annotations-22.2.0" level="project" /> | |||
| <orderEntry type="library" exported="" name="jackson-core-2.2.2" level="project" /> | |||
There was a problem hiding this comment.
@htcbug Any idea why these lines are needed?
|
@htcbug overall it looks good, but I have a few comments. Address those (either in code or by responding) and assign the PR back to me. |
|
I'm going to merge this in to master. Any more changes will end up there or on a new branch. |
puf
added a commit
that referenced
this pull request
Aug 22, 2015
Add a DemoApplication and RecyclerViewDemoActivity as sample
samtstern
pushed a commit
that referenced
this pull request
Dec 22, 2016
Closed
TomWayne98
pushed a commit
to TomWayne98/FirebaseUI-Android
that referenced
this pull request
Mar 6, 2017
TomWayne98
pushed a commit
to TomWayne98/FirebaseUI-Android
that referenced
this pull request
Oct 25, 2017
All layouts are fully accesible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@puf
Hi Frank,
Please review this change. It adds a DemoApplication and a RecyclerViewDemoActivity. After this change I'll add more code using the FirebaseRecyclerViewAdapter and merge my changes into it.