Skip to content

Update and fix deps #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2017
Merged

Update and fix deps #756

merged 2 commits into from
Jun 15, 2017

Conversation

SUPERCILEX
Copy link
Collaborator

@SUPERCILEX SUPERCILEX commented Jun 15, 2017 •
edited
Loading

@SUPERCILEX SUPERCILEX mentioned this pull request Jun 15, 2017
Merged
SUPERCILEX
SUPERCILEX commented Jun 15, 2017
View reviewed changes
library/google-services.json Outdated
"firebase_url": "",
"project_id": "",
"storage_bucket": ""
"project_number": "316052285104",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

com.google.gms:google-services:3.1.0 complained with these empty values so I just provided my dummy project ones.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just put some actual dummy values then? I know there's nothing bad about leaking yours but it feels a little odd...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, rebased.

@samtstern
Copy link
Contributor

@SUPERCILEX thank you for solving this! Much better, just left one comment.

@samtstern
Copy link
Contributor

@SUPERCILEX d'oh looks like the plugin can detect obviously fake values.

Here's a fake JSON file I've made that works:
https://github.com/firebase/quickstart-android/blob/master/mock-google-services.json

You can copy the values you need out of that.

@SUPERCILEX
Copy link
Collaborator Author

@samtstern Dang, that's a hardcore google-services.json you have there!😆 Thanks!

@samtstern samtstern merged commit b348218 into firebase:master Jun 15, 2017
@SUPERCILEX SUPERCILEX deleted the control-deps branch June 15, 2017 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samtstern samtstern samtstern left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SUPERCILEX @samtstern