Transforms #186
Merged
Transforms #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganchen12
force-pushed
the
transforms
branch
4 times, most recently
from
ac9c308 to
d612ac1
Compare
|
cc @puf, who may have opinions on this |
morganchen12
force-pushed
the
transforms
branch
2 times, most recently
from
3369669 to
1521daf
Compare
morganchen12
force-pushed
the
transforms
branch
from
6d5f685 to
01e5070
Compare
This was referenced Dec 9, 2016
morganchen12
force-pushed
the
transforms
branch
from
01e5070 to
04c78c0
Compare
morganchen12
force-pushed
the
transforms
branch
from
04c78c0 to
4b7a264
Compare
morganchen12
force-pushed
the
transforms
branch
from
41ed07e to
4cf3b1e
Compare
puf
reviewed
Jan 3, 2017
|
|
||
| @optional | ||
|
|
||
| /** | ||
| * Called before any other events are sent. | ||
| */ | ||
| - (void)arrayDidBeginUpdates:(id<FUICollection>)collection; |
There was a problem hiding this comment.
I intentionally did not add a "begin updates" event, but only a "we're done with all updates". What do you think you would catch in this method that you would catch with a simple "is this the first update?" check?
There was a problem hiding this comment.
This is just to better mirror the UIKit aggregation methods of beginUpdates and endUpdates. This makes it easier for consumers, so they don't have to track their own local state.
There was a problem hiding this comment.
I suspect it's ok to drop the beginUpdates event if the platform doesn't call for it. :)
This was referenced Jan 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for defining transformations (i.e. sort) on the data from FirebaseDatabase before it's presented in a table/collection view. Still missing a few things. Addresses #183, depends on
#184. Also allows for consumers to create their own collections.Doc commentsDRY code in collectionsTests@mcdonamp please review