Skip to content

Deprecate FUITwitterAuth. They will be removed #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Deprecate FUITwitterAuth. They will be removed #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions TwitterAuth/FirebaseTwitterAuthUI/FUITwitterAuth.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ NS_ASSUME_NONNULL_BEGIN
/** @class FUITwitterAuth
@brief AuthUI components for Twitter Sign In.
*/
DEPRECATED_MSG_ATTRIBUTE("Please use FUIOAuth instead of FUITwitterAuth.")
@interface FUITwitterAuth : NSObject <FUIAuthProvider>

@end
Expand Down
5 changes: 5 additions & 0 deletions TwitterAuth/FirebaseTwitterAuthUI/FUITwitterAuth.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@
#import "FUIAuthStrings.h"
#import "FUIAuthUtils.h"

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"

/** @var kTableName
@brief The name of the strings table to search for localized strings.
*/
Expand Down Expand Up @@ -158,3 +161,5 @@ - (Twitter *)getTwitterManager {
}

@end

#pragma clang diagnostic pop
6 changes: 4 additions & 2 deletions TwitterAuth/FirebaseTwitterAuthUI/FirebaseTwitterAuthUI.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,12 @@
#import <UIKit/UIKit.h>

//! Project version number for FirebaseTwitterAuthUI.
FOUNDATION_EXPORT double FirebaseTwitterAuthUIVersionNumber;
FOUNDATION_EXPORT double FirebaseTwitterAuthUIVersionNumber
DEPRECATED_MSG_ATTRIBUTE("Please use OAuth instead of TwitterAuth.");

//! Project version string for FirebaseTwitterAuthUI.
FOUNDATION_EXPORT const unsigned char FirebaseTwitterAuthUIVersionString[];
FOUNDATION_EXPORT const unsigned char FirebaseTwitterAuthUIVersionString[]
DEPRECATED_MSG_ATTRIBUTE("Please use OAuth instead of TwitterAuth.");

#import "FUITwitterAuth.h"

Expand Down
3 changes: 3 additions & 0 deletions samples/objc/FirebaseUI-demo-objc/Samples/Auth/FUIAuthViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,10 @@ + (NSArray *)getListOfIDPs:(NSArray<NSIndexPath *> *)selectedRows
:[[FUIFacebookAuth alloc] init];
break;
case kIDPTwitter:
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
provider = [[FUITwitterAuth alloc] init];
#pragma clang diagnostic pop
break;
case kIDPPhone:
provider = [[FUIPhoneAuth alloc] initWithAuthUI:[FUIAuth defaultAuthUI]];
Expand Down
50 changes: 25 additions & 25 deletions samples/swift/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,43 +60,43 @@ PODS:
- FirebaseAuthInterop (~> 1.0)
- FirebaseCore (~> 5.2)
- GTMSessionFetcher/Core (~> 1.1)
- FirebaseUI (6.1.1):
- FirebaseUI/Anonymous (= 6.1.1)
- FirebaseUI/Auth (= 6.1.1)
- FirebaseUI/Database (= 6.1.1)
- FirebaseUI/Email (= 6.1.1)
- FirebaseUI/Facebook (= 6.1.1)
- FirebaseUI/Firestore (= 6.1.1)
- FirebaseUI/Google (= 6.1.1)
- FirebaseUI/OAuth (= 6.1.1)
- FirebaseUI/Phone (= 6.1.1)
- FirebaseUI/Storage (= 6.1.1)
- FirebaseUI/Twitter (= 6.1.1)
- FirebaseUI/Anonymous (6.1.1):
- FirebaseUI (6.2.1):
- FirebaseUI/Anonymous (= 6.2.1)
- FirebaseUI/Auth (= 6.2.1)
- FirebaseUI/Database (= 6.2.1)
- FirebaseUI/Email (= 6.2.1)
- FirebaseUI/Facebook (= 6.2.1)
- FirebaseUI/Firestore (= 6.2.1)
- FirebaseUI/Google (= 6.2.1)
- FirebaseUI/OAuth (= 6.2.1)
- FirebaseUI/Phone (= 6.2.1)
- FirebaseUI/Storage (= 6.2.1)
- FirebaseUI/Twitter (= 6.2.1)
- FirebaseUI/Anonymous (6.2.1):
- FirebaseUI/Auth
- FirebaseUI/Auth (6.1.1):
- Firebase/Auth (~> 5.0)
- FirebaseUI/Auth (6.2.1):
- Firebase/Auth (~> 5.4)
- GoogleUtilities/UserDefaults
- FirebaseUI/Database (6.1.1):
- FirebaseUI/Database (6.2.1):
- Firebase/Database (~> 5.0)
- FirebaseUI/Email (6.1.1):
- FirebaseUI/Email (6.2.1):
- FirebaseUI/Auth
- FirebaseUI/Facebook (6.1.1):
- FirebaseUI/Facebook (6.2.1):
- FBSDKLoginKit (~> 4.35)
- FirebaseUI/Auth
- FirebaseUI/Firestore (6.1.1):
- FirebaseUI/Firestore (6.2.1):
- Firebase/Firestore
- FirebaseUI/Google (6.1.1):
- FirebaseUI/Google (6.2.1):
- FirebaseUI/Auth
- GoogleSignIn (~> 4.0)
- FirebaseUI/OAuth (6.1.1):
- FirebaseUI/OAuth (6.2.1):
- FirebaseUI/Auth
- FirebaseUI/Phone (6.1.1):
- FirebaseUI/Phone (6.2.1):
- FirebaseUI/Auth
- FirebaseUI/Storage (6.1.1):
- FirebaseUI/Storage (6.2.1):
- Firebase/Storage (~> 5.0)
- SDWebImage (~> 4.0)
- FirebaseUI/Twitter (6.1.1):
- FirebaseUI/Twitter (6.2.1):
- FirebaseUI/Auth
- TwitterKit (~> 3.0)
- GoogleSignIn (4.4.0):
Expand Down Expand Up @@ -192,7 +192,7 @@ SPEC CHECKSUMS:
FirebaseDatabase: 23acb0c53cd4d4070a427b60100b2e4aaa97c45d
FirebaseFirestore: ccdaffb8a73c591ff61872b8f7905ad0c237ef50
FirebaseStorage: 29075f874c2b3cf61e5221a62c4ceefc809e5412
FirebaseUI: fc3584df29e96959d895677274681939fa30dbe5
FirebaseUI: 68cf8bcb7b770c397f13379657268e4193b300d6
GoogleSignIn: 7ff245e1a7b26d379099d3243a562f5747e23d39
GoogleToolboxForMac: ff31605b7d66400dcec09bed5861689aebadda4d
GoogleUtilities: fa768ad04b264be250ee9edf9f378ad006f7a560
Expand Down