Snippets for bulk get/delete function #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsgowman
force-pushed
the
rsgowman/bulk_get_delete_snippets
branch
2 times, most recently
from
4c449aa to
7555672
Compare
Corresponding doc change to enable it: http://cl/282953279
rsgowman
force-pushed
the
rsgowman/bulk_get_delete_snippets
branch
from
7555672 to
da2fc72
Compare
samtstern
approved these changes
May 29, 2020
hiranya911
approved these changes
May 29, 2020
Contributor
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
LGTM with a suggestion
snippets/auth.go
Outdated
| providerUID := "google_uid1" | ||
| // [START bulk_get_users_golang] | ||
| getUsersResult, err := client.GetUsers(ctx, []auth.UserIdentifier{ | ||
| auth.UIDIdentifier{UID: uid}, |
Contributor
There was a problem hiding this comment.
May be inline the values of uid, email etc for clarity.
Member
Author
There was a problem hiding this comment.
Done. I've also applied this to bulk delete (despite it just being uids.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding doc change to enable it: http://cl/282953279