feat(auth): enables OIDC Auth code flow #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides an option for developers to specify the OAuth response type for their OIDC provider (either one of these can be set:): id_token code (if set, must also set the client secret)
lahirumaramba
requested changes
Dec 7, 2021
Member
lahirumaramba
left a comment
lahirumaramba
left a comment
There was a problem hiding this comment.
Thanks, Ryan! Added a few comments.
added 2 commits
December 8, 2021 09:11
lahirumaramba
approved these changes
Dec 9, 2021
Member
lahirumaramba
left a comment
lahirumaramba
left a comment
There was a problem hiding this comment.
Thank you!
LGTM with minor comments. Let's get the reference docs reviewed as well.
auth/provider_config.go
Outdated
| if val, ok := config.params.Get(idTokenResponseTypeKey); ok && val.(bool) { | ||
| return nil, "", errors.New("Only one response type may be chosen") | ||
| } | ||
| } else { |
Member
There was a problem hiding this comment.
Can this be a } else if {? and same below.
auth/provider_config.go
Outdated
| } | ||
| } | ||
|
|
||
| if val, ok := config.params.Get(codeResponseTypeKey); ok && !val.(bool) { |
Member
There was a problem hiding this comment.
Can codeResponseTypeKey ever be undefined? if not, I think you can use else if here.
lahirumaramba
requested review from
kevinthecheung
and removed request for
egilmorez
kevinthecheung
approved these changes
Dec 10, 2021
lahirumaramba
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides an option for developers to specify the OAuth response type for
their OIDC provider (either one of these can be set:):
id_token
code (if set, must also set the client secret)
RELEASE NOTE: Added support for configuring the authorization code flow for OIDC providers.