Skip to content

chore: Bumped minimum go version to 1.15 #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2022
Merged

chore: Bumped minimum go version to 1.15 #485

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba18c9a
chore: Bumped minimum go version to 1.15
lahirumaramba Mar 4, 2022
638aa00
Update appengine build tags for 1.17
lahirumaramba Mar 4, 2022
bafb2f1
PR fixes
lahirumaramba Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
strategy:
fail-fast: false
matrix:
go: [1.12, 1.16]
go: [1.15, 1.17]

steps:
- name: Set up Go ${{ matrix.go }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v1
with:
go-version: 1.12
go-version: 1.15

- name: Install golint
run: go get golang.org/x/lint/golint
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v1
with:
go-version: 1.12
go-version: 1.15

- name: Install golint
run: go get golang.org/x/lint/golint
Expand Down
5 changes: 3 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,10 @@ requests, code review feedback, and also pull requests.

## Supported Go Versions

We support Go v1.12 and higher.
Admin Go SDK is compatible with at least the three most recent, major Go releases.
Copy link

@egilmorez egilmorez Mar 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truly a nit, but "The Admin Go SDK" reads a little nicer.

Copy link
Member Author

@lahirumaramba lahirumaramba Mar 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks! Updated.

We currently support Go v1.15 and higher.
[Continuous integration](https://github.com/firebase/firebase-admin-go/actions) system
tests the code on Go v1.12 through v1.14.
tests the code on Go v1.15 through v1.17.

## Documentation

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module firebase.google.com/go/v4

go 1.11
go 1.15

require (
cloud.google.com/go/firestore v1.5.0
Expand Down