fix: Use the correct deprecated syntax in code #531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahirumaramba
approved these changes
Mar 23, 2023
Member
lahirumaramba
left a comment
lahirumaramba
left a comment
There was a problem hiding this comment.
Thank you @shogo82148 ! LGTM
Member
|
The base branch needs to be changed to |
The godoc of deprecated types, values and functions should be match the regexp `(^|\n\s*\n)\s*Deprecated:`. https://github.com/golang/pkgsite/blob/8996ff632abee854aef1b764ca0501f262f8f523/internal/godoc/dochtml/deprecated.go#L12-L13 pkg.go.dev marks these items deprecated and show them using a special style.
shogo82148
force-pushed
the
mark-deprecated-on-pkgsite
branch
from
69c16cf to
679432b
Compare
lahirumaramba
changed the title
lahirumaramba
changed the title
lahirumaramba
approved these changes
Apr 6, 2023
Member
lahirumaramba
left a comment
lahirumaramba
left a comment
There was a problem hiding this comment.
Thank you for your contribution! LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The godoc of deprecated types, values and functions should be match the regexp
(^|\n\s*\n)\s*Deprecated:.https://github.com/golang/pkgsite/blob/8996ff632abee854aef1b764ca0501f262f8f523/internal/godoc/dochtml/deprecated.go#L12-L13
pkg.go.dev marks these items deprecated and show them using a special style.
e.g. https://pkg.go.dev/net/http#CloseNotifier