-
Notifications
You must be signed in to change notification settings - Fork 271
feat(auth): Add TotpInfo field to UserRecord
#573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Xiaoshouzi-gh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM.
Optional - To gradually improve the coding practice, we can start clean up while we touching the existing code. For example, we can start moving repeated string in test cases in constants.
TotpInfo field to UserRecord
lahirumaramba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall! Thank you! Added a few more comments.
1ed9e4d to
115918b
Compare
|
Good Afternoon Team 👋🏻 Any status updates on getting this MR merged in? Thanks! |
|
@pragatimodi 👋🏻 Thanks for pushing the changes to get this merged into the Do you have any idea on when my team can see it pushed to a new version? Thanks! |
|
@pragatimodi Can you please provide ETA on the next release of SDK that has this feature. A critical release is blocked due to this feature missing in the current version of SDK |
|
@lahirumaramba Please provide an update on the estimated release for this? |
|
@lahirumaramba Can you please provide ETA for the next release, as i stated earlier a critical release is blocked due to this. We tried to reach out to GCP premium support if but they pointed us here |
|
Thanks for your patience folks! We will include this change in the planned upcoming release this week. |
Original PR based off
masterThis is based off
devbranch.