chore: Add X-Goog-Api-Client metric header to outgoing requests
#655
Conversation
appcheck/appcheck.go
Outdated
| jwks, err := keyfunc.Get(JWKSUrl, keyfunc.Options{ | ||
| Ctx: ctx, | ||
| RefreshInterval: 6 * time.Hour, | ||
| RequestFactory: makeRequestFactory(conf), |
There was a problem hiding this comment.
Only way to pass headers here is to pass it through a request factory. This is a little more involved, should I separate this change into it's own PR?
There was a problem hiding this comment.
Since this request is just for the key server (we might not track the requests there anyways) let's skip it for now then.
lahirumaramba
left a comment
lahirumaramba
left a comment
There was a problem hiding this comment.
LGTM
Added one comment on passing in the version to the helper function
| } | ||
|
|
||
| // GetMetricsHeader constructs header value for metrics attribution | ||
| func GetMetricsHeader(sdkVersion string) string { |
There was a problem hiding this comment.
Is it possible to access the Version in here? That might be better than passing it in from all the APIs separately.
There was a problem hiding this comment.
Not possible, that would cause a dependency cycle. I'm not a fan of how this is structured either. I would prefer if we kept the Version value separately from firebase.go.
2 participants
Includes:
This does not include: