chore: Update FAC to beta #1263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lahirumaramba
commented
May 10, 2021
lahirumaramba
commented
- Update to beta
- Add integration test for verify token api
lahirumaramba
force-pushed
the
lm-fac-beta
branch
from
a4db18f to
7516c92
Compare
weixifan
reviewed
May 10, 2021
| @@ -147,9 +147,9 @@ export class AppCheckApiClient { | |||
| */ | |||
| private toAppCheckToken(resp: HttpResponse): AppCheckToken { | |||
| const token = resp.data.attestationToken; | |||
| // `timeToLive` is a string with the suffix "s" preceded by the number of seconds, | |||
| // `ttl` is a string with the suffix "s" preceded by the number of seconds, | |||
There was a problem hiding this comment.
Interesting -- unrelated to this review, the ttl is actually a textual representation of a Duration proto as per AIP-142 and the Duration documentation. The only downside is that parsing it via Duration might cost us an additional dependency.
There was a problem hiding this comment.
Yeah. I think for Javascript (Node.js) we can parse the JSON by referring to the JSON Mapping section in the proto. Can confirm that the JS SDK follows the same approach.
|
LGTM! |
weixifan
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.