Skip to content

fix: Remove CR (\r) from generated content #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Conversation

hiranya911
Copy link
Contributor

Our API doc post processing script currently writes line endings with \r\n. Apparently devsite doesn't like that. Just using \n which seems to be acceptable to the devsite publishing tools.

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@lahirumaramba lahirumaramba assigned hiranya911 and unassigned egilmorez Oct 1, 2021
@hiranya911 hiranya911 merged commit 8ab8a45 into modular-sdk Oct 1, 2021
@hiranya911 hiranya911 deleted the hkj-no-cr branch October 1, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants