Skip to content

fix(firestore): Expose more types from gcp firestore #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

lahirumaramba
Copy link
Member

Exported types BundleBuilder, DocumentChange, OrderByDirection, SetOptions, and WhereFilterOp from firestore/index.ts and firestore-namespace.ts.

RELEASE NOTE: Exposed BundleBuilder, DocumentChange, OrderByDirection, SetOptions, and WhereFilterOp Firestore SDK types from the firestore module and the admin.firestore namespace.

Resolves: #1472

@lahirumaramba lahirumaramba force-pushed the lm-export-firestore-types branch from 8fcf18e to 9a2ab54 Compare December 6, 2021 19:57
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

@lahirumaramba lahirumaramba merged commit 0e44972 into master Dec 6, 2021
@lahirumaramba lahirumaramba deleted the lm-export-firestore-types branch December 6, 2021 22:12
lahirumaramba added a commit that referenced this pull request Dec 15, 2021
- Added the new types exposed in #1513 and a few other missing types from the docs
lahirumaramba added a commit that referenced this pull request Dec 15, 2021
* Add new Firestore types exposed in 1513

- Added the new types exposed in #1513 and a few other missing types from the docs

* Clean up the links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants