feat(auth): Support generate oob code request type VERIFY_AND_CHANGE_EMAIL #1633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…generation method. Added more unit tests. Updated the method name.
renkelvin
approved these changes
Apr 21, 2022
| * mobile app or browser along with additional state information to be passed in | ||
| * the deep link, etc. | ||
| * | ||
| * @param email - The current email account. |
There was a problem hiding this comment.
Kept it as email account as the previous public method (verify_email, reset_password etc) uses the same documentation on email paramater. Let me know if you feel strong about email address.
lahirumaramba
approved these changes
Apr 27, 2022
lahirumaramba
changed the title
lahirumaramba
changed the title
|
Please get TW's approval on the reference docs before you merge this. Thank you! |
kevinthecheung
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support generate email link for VERIFY_AND_CHANGE_EMAIL action.
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.