Use ID token from metadata server when sending tasks for extensions #1812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahirumaramba
approved these changes
Jul 14, 2022
| */ | ||
| function requestIDToken(client: HttpClient, request: HttpRequestConfig): Promise<string> { | ||
| return client.send(request).then((resp) => { | ||
| return resp.text || ''; |
There was a problem hiding this comment.
Should we explicitly handle the cases where resp.text is undefined, or is it safe to just return an empty token here?
There was a problem hiding this comment.
Good call - we probably should throw in this case (since if were requesting an id token & get an empty string, we'll almost certainly get an error later).
| : await this.getUrl(resources, FIREBASE_FUNCTION_URL_FORMAT); | ||
| task.httpRequest.url = functionUrl; | ||
| // When run from a deployed extension, we should be using ComputeEngineCredentials | ||
| if (extensionId && this.app.options.credential instanceof ComputeEngineCredential) { |
There was a problem hiding this comment.
Can we use validator.isNonEmptyString(extensionId) here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an ID token from the compute metadata server when sending tasks from an extension.