Skip to content

Rectified issues in comments for NotificationMessagePayload #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 12, 2020

Conversation

VPanjeta
Copy link
Contributor

@VPanjeta VPanjeta commented May 7, 2020

The comments regarding the NotificationMessagePayload were not correct. They were placed with different options.
The comment related to tag was attached to sound and tag did not have any comment attached.

Had an issue understanding the payload the first time I opened the installed directory to go through the payload of sendToDevice

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@VPanjeta
Copy link
Contributor Author

VPanjeta commented May 7, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@lahirumaramba
Copy link
Member

Thank you @VPanjeta !

Looks like this was previously addressed in #820, but was broken by #751 right after.

@lahirumaramba lahirumaramba requested a review from egilmorez May 7, 2020 17:52
*
* **Platforms:** Android
* The sound to be played when the device receives the
* notification.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/**
     * The sound to play when the device receives the notification. Supports
     * "default" or the filename of a sound resource bundled in the app. Sound files
     * must reside in `/res/raw/`.
     * 
     * **Platforms:** Android
     */

I think the docs from #820 might be more suitable here. I will leave @egilmorez to confirm.

@hiranya911 hiranya911 assigned egilmorez and unassigned hiranya911 May 7, 2020
@hiranya911 hiranya911 removed their request for review May 7, 2020 18:53
@VPanjeta
Copy link
Contributor Author

Ok since it is already present in #820 . Closing this for now.

@VPanjeta VPanjeta closed this May 11, 2020
@lahirumaramba
Copy link
Member

It was addressed in #820 but was broken again in #751. Therefore we could still use this PR.
Please update the comments (docs) to the suggested text in my review and we should be good to merge this. Thanks!

@lahirumaramba lahirumaramba reopened this May 11, 2020
@VPanjeta
Copy link
Contributor Author

@lahirumaramba Made the changes as expected. Do let me know if anything else is needed.

* If specified and a notification with the same tag is already being shown,
* the new notification replaces the existing one in the notification drawer.
*
* The sound to be played when device receives a notification. Supports
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are using articles everywhere else (instead of the extra-concise style that omits them), we should probably use them here too:

"The sound to be played when the device receives a notification. Supports
* * "default" for the default notification sound of the device"

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending! LG with one nit regarding articles.

@VPanjeta
Copy link
Contributor Author

@egilmorez Sorry for having some semantic/grammatical errors. English isn't my native language. Pushed a commit after adding articles to the comments. Hopefully that fixes your concerns.
Do let me know if I'm still missing something.

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @VPanjeta !
LGTM!

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants