feat(auth): Adding multi-tenancy and IdP management APIs #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(auth): Added Tenant class and get_tenant() API * Added delete_tenant() API * Added delete_tenant to _all_ list * Fixing a lint error * Fixing a lint error
* Create tenant API * Added update tenant API * Added docstring to fix lint error
* Added list_tenants() API * Update firebase_admin/tenant_mgt.py Co-Authored-By: Lahiru Maramba <[email protected]> * Updated error message Co-authored-by: Lahiru Maramba <[email protected]>
* Adding tenant_mgt.auth_for_tenant() API * Added more tenant-aware user mgt tests * Full test coverage for tenant-aware user mgt APIs * Updated docstring to fix lint error * Removed unused var; Fixing lint error
* Tenant-aware ID token verification support * Extended InvalidArgumentError in TenantIdMismatchError * Fixing lint errors
* Added tenant-scoped custom token support * Fixed a lint error; Improved test assertion
* Renamed _AuthService to Client * Renamed some local variables for consistency * Added documentation to Client APIs * Fixed doc lint error
* feat(auth): Adding SAMLProviderConfig type and the getter method * Added ConfigurationNotFoundError type * Fixing a lint error related to super delegation
* feat(auth): Added create_saml_provider_config() API * Added update_saml_provider_config() API * Moved auth.Client to a separate submodule * Moved auth.Client; Updated docs
* feat(auth): Added delete_saml_provider_config() API * Preliminary list provider config impl * Refactored the common paging logic into base classes * Added more tests for list API
* feat(auth): Added OIDCProviderConfig type and get/delete APIs * Added newline to eof
#446) * fix(auth): Integration tests for IdP management APIs * More integration tests for tenant_mgt module; Made display_name required for tenants * Integration tests for tenant-aware IdP management * Fixing lint error; Added unit test for UserRecord.tenant_id * Trigger staging * Added unit tests for tenant names longer than 20 chars
|
@egilmorez please review the release notes, and the docstring chages in following files:
|
egilmorez
reviewed
Apr 17, 2020
There was a problem hiding this comment.
A lot of doc strings here! :)
Can I make one global request -- that you go through the strings looking for values that should be backticked as literals? I started marking them, but realized it might be more efficient to let you make a pass with that in mind. Things like:
AuthProviderConfig instances >> AuthProviderConfig instances
None >> None
Tenant object >> Tenant object
LMK if that doesn't make sense. In many of these places it might be possible to just use general references to things like "a user record" instead of "a UserRecord instance.
Thanks!
|
@egilmorez made the suggested changes, and also did some additional changes to apply backticks where necessary. I think I've got nearly all of them. |
lahirumaramba
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTE: Added a new
tenant_mgtmodule that provides APIs for creating, updating, retrieving, and deleting authentication tenants.RELEASE NOTE: Added a new
tenant_mgt.auth_for_tenant()function that returns a client object scoped to a specific tenant for performing tenant-aware user management operations.RELEASE NOTE: Added the
auth.OIDCProviderConfigtype and related functions to create, retrieve, update and delete OIDC auth provider configurations.RELEASE NOTE: Added the
auth.SAMLProviderConfigtype and related functions to create, retrieve, update and delete SAML auth provider configurations.Resolves #353