Skip to content

Added return type for bucket function #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sarmadgulzar
Copy link
Contributor

Added google.cloud.storage.Bucket return type for storage.bucket function for better typing support

@lahirumaramba lahirumaramba self-requested a review November 25, 2021 16:29
@lahirumaramba lahirumaramba self-assigned this Nov 25, 2021
@sarmadgulzar
Copy link
Contributor Author

@lahirumaramba how can I rerun the CLA workflow? I wasn't aware of this so I only signed up after the check failed!

@lahirumaramba
Copy link
Member

@lahirumaramba how can I rerun the CLA workflow? I wasn't aware of this so I only signed up after the check failed!

Thank you! I triggered the CLA check.

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sarmadgulzar for the contribution! LGTM!

@lahirumaramba lahirumaramba merged commit 348a90d into firebase:master Nov 30, 2021
@sarmadgulzar sarmadgulzar deleted the add-a-missing-return-type branch December 4, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants