Remove test duplication #2494
Merged
Remove test duplication #2494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This merges the ObjectValue and MutableObjectValue tests. They used to be different since we had ObjectValue and ObjectValueBuilder. The PR also makes an effort to remove test duplication, but makes no guarantees here.
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (87880934) is created by Prow via merging commits: 7bcedca 327c3bf. |
Binary Size ReportAffected SDKsNo changes between base commit (7bcedca) and head commit (87880934). Test Logs
NotesHead commit (87880934) is created by Prow via merging commits: 7bcedca 327c3bf. |
dconeybe
approved these changes
Mar 10, 2021
| private Value emptyObject = Value.newBuilder().setMapValue(MapValue.getDefaultInstance()).build(); | ||
|
|
||
| @Test | ||
| public void supportsEmptyObjectValues() { |
There was a problem hiding this comment.
nit: All of the other test methods in this class have their names prefixed with "test". Can you rename supportsEmptyObjectValues to also follow this convention?
This was referenced Mar 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the ObjectValue and MutableObjectValue tests. They used to be different since we had ObjectValue and ObjectValueBuilder. The PR also makes an effort to remove test duplication, but makes no guarantees here.