Skip to content

carbon-copy of the optional-relevant src from abseil #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2018
Merged

carbon-copy of the optional-relevant src from abseil #1083

merged 1 commit into from
Apr 13, 2018

Conversation

zxu123
Copy link
Contributor

@zxu123 zxu123 commented Apr 13, 2018

Based on abseil version bf7fc99, the same version as the other imported abseil libraries. Import abseil::optional and dependency files.

@zxu123 zxu123 changed the base branch from master to abseil-mirror April 13, 2018 01:48
@zxu123 zxu123 requested review from var-const and rsgowman April 13, 2018 01:49
rsgowman
rsgowman approved these changes Apr 13, 2018
View reviewed changes
Copy link
Member

@rsgowman rsgowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is all 100% absl without any changes by us. Conditional on that, this lgtm.

@zxu123 zxu123 requested a review from wilhuff April 13, 2018 15:41
wilhuff
wilhuff approved these changes Apr 13, 2018
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zxu123 zxu123 merged commit c1061b7 into abseil-mirror Apr 13, 2018
@zxu123 zxu123 deleted the cpp/port_optional_unchanged branch April 13, 2018 18:40
wilhuff added a commit that referenced this pull request Apr 15, 2018
@wilhuff
Update abseil-cpp to a new upstream
dfb5c04 
Actually update to bf7fc9986e20f664958fc227547fd8d2fdcf863e

Change #754 didn't completely do this.

This makes the rest of the sources match optional, which was imported at
this change in #1083.

Also add:
  absl/types/optional_test.cc
  absl/types/CMakeLists.txt
  absl/utility/CMakeLists.txt
@wilhuff wilhuff mentioned this pull request Apr 15, 2018
Merged
minafarid pushed a commit to minafarid/firebase-ios-sdk that referenced this pull request Jun 6, 2018
@zxu123
carbon-copy of the optional-relevant src from abseil (firebase#1083)
4691ed2
minafarid pushed a commit to minafarid/firebase-ios-sdk that referenced this pull request Jun 6, 2018
@wilhuff
Update abseil-cpp to a new upstream
e904797 
Actually update to bf7fc9986e20f664958fc227547fd8d2fdcf863e

Change firebase#754 didn't completely do this.

This makes the rest of the sources match optional, which was imported at
this change in firebase#1083.

Also add:
  absl/types/optional_test.cc
  absl/types/CMakeLists.txt
  absl/utility/CMakeLists.txt
@firebase firebase locked and limited conversation to collaborators Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

@rsgowman rsgowman rsgowman approved these changes

@var-const var-const Awaiting requested review from var-const

Assignees
No one assigned
Labels
api: firestore cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zxu123 @wilhuff @rsgowman @googlebot