Skip to content

Rename product to Firebase AI - Part 1 #14725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Rename product to Firebase AI - Part 1 #14725

wants to merge 10 commits into from

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Apr 15, 2025

Source and SPM changes to update packages and classes consistent with Firebase AI SDK product naming

See individual commits for incremental transformations

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@paulb777
Copy link
Member Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request renames the product to Firebase AI, updating packages and classes accordingly. The changes seem well-organized and consistent with the new naming convention. However, some areas could benefit from further clarification and potential improvements.

Summary of Findings

  • Inconsistent naming in VertexAI.swift: The VertexAI class in VertexAI.swift still uses the old naming convention, which might be confusing for developers using the legacy module. Consider updating or deprecating this class to align with the new Firebase AI naming.
  • Redundant API Config Assertions: The assertions for apiConfig.service and apiConfig.version in GenAI.swift seem redundant. Consider removing the duplicate assertion to simplify the code.
  • Missing Documentation Update: The documentation in GenAI.swift still refers to Vertex AI for Firebase. Update the documentation to reflect the new Firebase AI naming.

Merge Readiness

The pull request is almost ready for merging. However, addressing the inconsistent naming in VertexAI.swift and updating the documentation in GenAI.swift would improve the overall clarity and consistency of the codebase. I am unable to approve this pull request, and recommend that these changes be reviewed and approved by others before merging.

@paulb777
Copy link
Member Author

Done in other PRs

@paulb777 paulb777 closed this Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants