-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Rename product to Firebase AI - Part 1 #14725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
Generated by 🚫 Danger |
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request renames the product to Firebase AI, updating packages and classes accordingly. The changes seem well-organized and consistent with the new naming convention. However, some areas could benefit from further clarification and potential improvements.
Summary of Findings
- Inconsistent naming in VertexAI.swift: The
VertexAI
class inVertexAI.swift
still uses the old naming convention, which might be confusing for developers using the legacy module. Consider updating or deprecating this class to align with the new Firebase AI naming. - Redundant API Config Assertions: The assertions for
apiConfig.service
andapiConfig.version
inGenAI.swift
seem redundant. Consider removing the duplicate assertion to simplify the code. - Missing Documentation Update: The documentation in
GenAI.swift
still refers to Vertex AI for Firebase. Update the documentation to reflect the new Firebase AI naming.
Merge Readiness
The pull request is almost ready for merging. However, addressing the inconsistent naming in VertexAI.swift
and updating the documentation in GenAI.swift
would improve the overall clarity and consistency of the codebase. I am unable to approve this pull request, and recommend that these changes be reviewed and approved by others before merging.
Done in other PRs |
Source and SPM changes to update packages and classes consistent with Firebase AI SDK product naming
See individual commits for incremental transformations