[realppl 6] offline ppl evaluation and tests #14852
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
Generated by 🚫 Danger |
| @@ -0,0 +1,387 @@ | |||
| /* | |||
There was a problem hiding this comment.
Many of these tests have built in assumption that collectionGroup returns documents ordered by document id. This is NOT a requirement, in fact:
"As with all other stages, the order of results from these input stages is not stable. A sort(...) operator should always be added if a specific ordering is desired." https://docs.google.com/document/d/1kyQzJs1jN0ntWydSK1aUSThUIjtlTiSdU9UtiGV8Nd4/edit?usp=sharing&resourcekey=0-U1zwV8bP87jt93iDgRwgcg
Having to sort results imposes additional computation, and possibly prevents optimization.
|
|
||
| PipelineInputOutputVector input_docs = {doc1, doc2, doc3, doc4}; | ||
| // Expected: charlie(97), bob(users, 90), bob(profiles, 90), alice(50) | ||
| // Stable sort preserves original relative order for ties (bob(users) before |
There was a problem hiding this comment.
Stable sort is not guaranteed.
"Sorting documents which contain equivalent values may be returned in any order. If a stable ordering is required, the sort keys should include a unique value. The simplest way to achieve this is just to add name to the ordering."
No description provided.