Port PrimitiveValueTest test for core::Query #1530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(From java.) Also fix a bug uncovered by the test. (oops)
var-const
approved these changes
Jul 13, 2018
| @@ -54,15 +54,15 @@ bool RelationFilter::MatchesValue(const FieldValue& other) const { | |||
| bool RelationFilter::MatchesComparison(const FieldValue& other) const { | |||
| switch (op_) { | |||
| case Operator::LessThan: | |||
| return value_ < other; | |||
| return other < value_; | |||
There was a problem hiding this comment.
Optional: this looks a little counterintuitive now that the order has been changed, due to the names. Unfortunately, I don't really have a good suggestion, but even renaming value_ to rhs_, though perhaps not elegant, would at least explain the ordering. (another rough idea is compare_what < compare_to_).
There was a problem hiding this comment.
I agree about the counterintuitive part (which is perhaps obvious, given that I originally reversed these!)
I've renamed value_ to value_rhs_
|
The travis failure was fixed in #1544. Merge the latest master to fix it. |
wilhuff
reviewed
Jul 16, 2018
| @@ -47,22 +49,22 @@ bool RelationFilter::Matches(const model::Document& doc) const { | |||
|
|
|||
| bool RelationFilter::MatchesValue(const FieldValue& other) const { | |||
| // Only compare types with matching backend order (such as double and int). | |||
| return FieldValue::Comparable(value_.type(), other.type()) && | |||
| return FieldValue::Comparable(value_rhs_.type(), other.type()) && | |||
There was a problem hiding this comment.
This now looks wrong (it's value_rhs_ but it's on the left).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(From java.)
Also fix a bug uncovered by the test. (oops)