Mutable Documents

[schmidt-sebastian]

This ports MutableDocument from Android: https://github.com/firebase/firebase-android-sdk/blob/master/firebase-firestore/src/main/java/com/google/firebase/firestore/model/MutableDocument.java

[google-oss-bot]

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

[google-oss-bot]

Coverage Report

Affected SDKs

• FirebaseFirestore-iOS-FirebaseFirestore.framework

  SDK overall coverage changed from 88.65% (5f6feba) to 88.32% (df11c49) by -0.33%.

  Filename	Base (5f6feba)	Head (df11c49)	Diff
  exception.cc	29.27%	65.85%	+36.59%
  grpc_nanopb.cc	100.00%	95.45%	-4.55%
  leveldb_key.cc	97.60%	96.48%	-1.12%
  mutable_document.cc	?	0.00%	?
  ordered_code.cc	93.24%	92.68%	-0.56%
  server_timestamp_util.cc	?	84.85%	?
  value_util.cc	?	89.16%	?
  watch_stream.cc	96.15%	92.31%	-3.85%
  write_stream.cc	95.65%	93.48%	-2.17%

Test Logs

• Base (5f6febab): https://github.com/firebase/firebase-ios-sdk/actions/runs/615408483
• Head (df11c49d): https://github.com/firebase/firebase-ios-sdk/actions/runs/661995379

[wu-hui]

We should also have some tests for this. Simply create documents, perform mutations and check they are in expected state should be good enough.

[schmidt-sebastian]

Thanks for the review!

I didn't add tests since this will be exhaustively tested by the LocalStoreTests once I plug this into the rest of the system. The existing document types follow the same testing strategy :)

[wu-hui]

LGTM!