Skip to content

UserDataWriter #7842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 13, 2021
Merged

UserDataWriter #7842

merged 7 commits into from
Apr 13, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Apr 5, 2021 •
edited
Loading

This ports UserDataWriter from Android.

@google-cla google-cla bot added the cla: yes label Apr 5, 2021
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/userdatawriter branch from 7472b1e to 8058736 Compare April 5, 2021 21:30
@google-oss-bot
Copy link

google-oss-bot commented Apr 8, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    SDK overall coverage changed from 88.51% (6eaf761) to 86.97% (47477a1) by -1.53%.

    Click to show coverage changes in 16 files.
    Filename Base (6eaf761) Head (47477a1) Diff
    FIRDocumentSnapshot.mm 89.84% 95.42% +5.58%
    FIRFirestore.mm 91.63% 91.61% -0.02%
    FIRTransaction.mm 97.71% 97.67% -0.04%
    FSTUserDataConverter_legacy.mm ? 0.00% ?
    FSTUserDataReader.mm ? 95.88% ?
    FSTUserDataWriter.mm ? 82.35% ?
    database_id.cc 71.43% 78.57% +7.14%
    document_key.cc 94.64% 95.31% +0.67%
    leveldb_key.cc 97.52% 97.96% +0.44%
    leveldb_migrations.cc 100.00% 93.40% -6.60%
    mutable_document.cc ? 0.00% ?
    object_value.cc ? 98.81% ?
    ordered_code.cc 92.68% 93.24% +0.56%
    serializer.cc 83.96% 84.56% +0.60%
    server_timestamp_util.cc ? 98.73% ?
    value_util.cc ? 88.34% ?

Test Logs

@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/userdatawriter branch from 6225d67 to 3e337bd Compare April 8, 2021 19:56
var-const
var-const suggested changes Apr 10, 2021
View reviewed changes
var-const
var-const approved these changes Apr 13, 2021
View reviewed changes
Firestore/core/src/model/server_timestamp_util.cc Outdated
map_value.fields =
nanopb::MakeArray<google_firestore_v1_MapValue_FieldsEntry>(count);

auto field = map_value.fields;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: s/auto/auto*/.

@schmidt-sebastian schmidt-sebastian merged commit e8960f9 into mrschmidt/mutabledocuments Apr 13, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/userdatawriter branch April 13, 2021 04:33
@firebase firebase locked and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@var-const var-const var-const approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @var-const