Run migration to rewrite canonical IDs #7850
Conversation
Generated by 🚫 Danger |
Coverage ReportAffected SDKs
Test Logs |
| #include "absl/strings/match.h" | ||
| #include "target_data.h" |
There was a problem hiding this comment.
Not 100%, but I think we mostly use absolute paths.
There was a problem hiding this comment.
I am going to blame Clion for this one.
| StringReader reader{target_it->value()}; | ||
| auto message = Message<firestore_client_Target>::TryParse(&reader); | ||
| if (!reader.ok()) { | ||
| HARD_FAIL("Target proto failed to parse: %s", reader.status().ToString()); |
There was a problem hiding this comment.
Can we return a failed status here (and below)? It is probably best not to crash during schema conversion since we load all existing data.
| auto query = Query("collection").AddingFilter(Filter("foo", "==", "bar")); | ||
| TargetData initial_target_data(query.ToTarget(), | ||
| /* target_id= */ 2, | ||
| /*sequence_numder*/ 1, QueryPurpose::Listen); |
There was a problem hiding this comment.
| /*sequence_numder*/ 1, QueryPurpose::Listen); | |
| /* sequence_numder= */ 1, QueryPurpose::Listen); |
|
|
||
| transaction.Delete(it->key()); | ||
| std::string empty_buffer; | ||
| transaction.Put(new_key, empty_buffer); |
There was a problem hiding this comment.
We need to write the old data back (empty_buffer sounds suspicious).
There was a problem hiding this comment.
This table always has empty value: https://osscs.corp.google.com/firebase-sdk/firebase-ios-sdk/+/master:Firestore/core/src/local/leveldb_target_cache.cc;l=110
It serves as an association between canonical id and target id.
|
|
||
| transaction.Delete(it->key()); | ||
| std::string empty_buffer; | ||
| transaction.Put(new_key, empty_buffer); |
No description provided.