Conversation
Collaborator
ncooke3
approved these changes
Apr 9, 2021
Comment on lines
-526
to
-535
| pod_gen FirebaseStorage.podspec --platforms=macos --clean | ||
| RunXcodebuild \ | ||
| -workspace 'gen/FirebaseStorage/FirebaseStorage.xcworkspace' \ | ||
| -scheme "FirebaseStorage-Unit-unit" \ | ||
| "${macos_flags[@]}" \ | ||
| "${xcb_flags[@]}" \ | ||
| build \ | ||
| test | ||
|
|
||
| pod_gen FirebaseStorage.podspec --platforms=tvos --clean |
Member
There was a problem hiding this comment.
Just so I understand better, why are we removing these from the build script? Are your changes to the pod-lib-lint task in storage.yml effectively replacing these parts of the build script?
Member
Author
There was a problem hiding this comment.
Yes. The unit tests now get run from pod lib lint. It's just recently possible because CocoaPods 1.10 introduced the feature of being able to select test_spec's to run instead of the all or none that it was previously.
Member
Author
|
Going to merge now, and can address any additional follow up in a subsequent PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Miscellaneous Storage CI cleanups
pod lib lint--no-modular-headersoption on cron#no-changelog