Fix Storage Integration Test CI #7874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
force-pushed
the
pb-fix-storage-int
branch
from
acf2278 to
b6adc0b
Compare
ncooke3
approved these changes
Apr 9, 2021
scripts/update_xcode_target.rb
Outdated
| end | ||
| end | ||
|
|
||
| #save project |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Storage integration tests have been silently failing ever since 7.0.0 after the GoogleServiceInfo.plist does not get found because FirebaseCore is linked dynamically as a separate bundle instead of statically into the app. https://github.com/firebase/firebase-ios-sdk/runs/2294766037?check_suite_focus=true#step:7:475
This fix uses a ruby script to update the Test Container app with the GoogleService-Info.plist so that it gets found at initialization.
Also, stop running Firestore test_coverage CI on script changes.
See successful Storage integration test logs at https://github.com/firebase/firebase-ios-sdk/runs/2308057031?check_suite_focus=true