ObjectValue changes #8007
Merged
ObjectValue changes #8007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| EXPECT_EQ(WrapObject("a", "object_value"), object_value); | ||
| object_value.Set(Field("a"), Wrap("object_value")); | ||
| object_value.Set(Field("a"), Value("object_value")); |
There was a problem hiding this comment.
Note: Value is the function name in master, so this actually reduces the diff.
Generated by 🚫 Danger |
var-const
reviewed
Apr 30, 2021
schmidt-sebastian
force-pushed
the
mrschmidt/ovchanges
branch
2 times, most recently
from
61e2c94 to
1479556
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/ovchanges
branch
from
1479556 to
3a0eb06
Compare
var-const
reviewed
May 4, 2021
| /** `MutableObjectValue` models unique ownership. */ | ||
| MutableObjectValue(const MutableObjectValue&) = delete; | ||
| MutableObjectValue& operator=(const MutableObjectValue&) = delete; | ||
| ObjectValue& operator=(const ObjectValue&) = delete; |
There was a problem hiding this comment.
Why is this class copy constructible but not copy assignable?
There was a problem hiding this comment.
I think I would need this operator:
|
@var-const Can you take another look? |
var-const
approved these changes
May 10, 2021
| /** `MutableObjectValue` models unique ownership. */ | ||
| MutableObjectValue(const MutableObjectValue&) = delete; | ||
| MutableObjectValue& operator=(const MutableObjectValue&) = delete; | ||
| ObjectValue& operator=(const ObjectValue&) = delete; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the larger series and renames MutableObjectValue to ObjectValue (the original ObjectValue is gone). It also adds support for unsorted MapValues, since the Watch backend does in fact send unsorted maps.