Skip to content

Preserve order in ArrayUnion #8050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2021
Merged

Preserve order in ArrayUnion #8050

merged 2 commits into from
May 11, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

The elements added in an ArrayUnion should be added in order.

@google-cla google-cla bot added the cla: yes label May 7, 2021
@schmidt-sebastian schmidt-sebastian requested a review from dconeybe May 7, 2021 15:22
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

dconeybe
dconeybe approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there test coverage for this case? If not, please add a test case.

@schmidt-sebastian
Copy link
Contributor Author

Test added

@schmidt-sebastian schmidt-sebastian merged commit e703e19 into mrschmidt/mutabledocuments May 11, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/preserve branch May 11, 2021 01:05
@firebase firebase locked and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @dconeybe