Random test migrations to Protobuf #8072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
thebrianchen
approved these changes
May 13, 2021
| Status resulting_status; | ||
| datastore->LookupDocuments( | ||
| {}, [&](const StatusOr<std::vector<MaybeDocument>>& maybe_documents) { | ||
| {}, [&](const StatusOr<std::vector<Document>>& maybe_documents) { |
| Status resulting_status; | ||
| datastore->LookupDocuments( | ||
| {}, [&](const StatusOr<std::vector<MaybeDocument>>& maybe_documents) { | ||
| {}, [&](const StatusOr<std::vector<Document>>& maybe_documents) { |
| expected_data = | ||
| expected_data.Set(Field("foo.bar"), FieldValue::FromServerTimestamp(now)); | ||
| expected_data.Set(Field("foo.bar"), | ||
| EncodeServerTimestamp(now, absl::nullopt)); |
There was a problem hiding this comment.
Not sure if you have another PR to fix this, but now has type Timestamp, but EncodeServerTimestamp requires google_protobuf_Timestamp.
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings tests in line with Android.