Skip to content

Change techwriter alias to individual account #4878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2021
Merged

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented May 6, 2021

It doesn't seem like the techwriters alias is working for triggering a suggested reviewer or assignee, change to individual account for now (@egilmorez) and see if it works better.

@changeset-bot
Copy link

changeset-bot bot commented May 6, 2021

⚠️ No Changeset found

Latest commit: 7b8c859

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is part of the problem that now doc strings come from many many other sources?

For instance, packages/app-check-types/index.d.ts :)

@hsubox76
Copy link
Contributor Author

hsubox76 commented May 6, 2021

Is part of the problem that now doc strings come from many many other sources?

For instance, packages/app-check-types/index.d.ts :)

No, that file doesn't affect doc generation, as v8 still only uses the single file. We will have to find a way to deal with that problem in exp packages though.

@Feiyang1 Feiyang1 assigned hsubox76 and unassigned Feiyang1 May 13, 2021
@hsubox76 hsubox76 merged commit d6e0242 into master May 21, 2021
@hsubox76 hsubox76 deleted the ch-codeowners branch May 21, 2021 16:28
@firebase firebase locked and limited conversation to collaborators Jun 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants