Skip to content

[Auth] Fix broken public typings d.ts file #5127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 9, 2021
Merged

[Auth] Fix broken public typings d.ts file #5127

merged 2 commits into from
Jul 9, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Jul 8, 2021

Fixes #5118

@sam-gc sam-gc requested review from Feiyang1 and yuchenshi July 8, 2021 18:37
@changeset-bot
Copy link

changeset-bot bot commented Jul 8, 2021

⚠️ No Changeset found

Latest commit: 2daa09e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2021

Changeset File Check ⚠️

  • Changeset formatting error in following file: 
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
If this change doesn't need a release, run `changeset add --empty`.

@github-actions github-actions bot added the doc-changes PRs that affect docs label Jul 8, 2021
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (c8ac613) and head commit (28115ee).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (c8ac613) and head commit (28115ee).

@Feiyang1 Feiyang1 added doc-changes PRs that affect docs and removed doc-changes PRs that affect docs labels Jul 8, 2021
@Feiyang1 Feiyang1 added this to the v9 GA milestone Jul 9, 2021
@Feiyang1 Feiyang1 added the v9 label Jul 9, 2021
@sam-gc sam-gc merged commit 2a2a376 into master Jul 9, 2021
@sam-gc sam-gc deleted the sam-gc/d.ts branch July 9, 2021 16:09
@firebase firebase locked and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees

@Feiyang1 Feiyang1

@egilmorez egilmorez

@yuchenshi yuchenshi

Labels
doc-changes PRs that affect docs v9
Projects
None yet
Milestone
v9 GA
Development

Successfully merging this pull request may close these issues.

Firebase v9 typescript declaration file fails to compile with error TS1254
5 participants
@sam-gc @google-oss-bot @Feiyang1 @yuchenshi @egilmorez