Always block on Auth #5340

schmidt-sebastian · 2021-08-20T23:09:22Z

This PR changes Firestore to block the AsyncQueue even if Auth is only available after startup. The queue is blocked from the moment that auth is detected until the SDK receives a user.

changeset-bot · 2021-08-20T23:09:24Z

⚠️ No Changeset found

Latest commit: 4a53235

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR

Some errors occurred when validating the changesets config:
The package "@firebase/firestore-compat" depends on the ignored package "@firebase/app-compat", but "@firebase/firestore-compat" is not being ignored. Please add "@firebase/firestore-compat" to the `ignore` option.

github-actions · 2021-08-20T23:17:48Z

Changeset File Check ⚠️

Changeset formatting error in following file:

Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.8" vs "file:../../packages-exp/firebase-exp"
ValidationError: Some errors occurred when validating the changesets config:
The package "@firebase/firestore-compat" depends on the ignored package "@firebase/app-compat", but "@firebase/firestore-compat" is not being ignored. Please add "@firebase/firestore-compat" to the `ignore` option.
    at async run$1 (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/cli/dist/cli.cjs.dev.js:1096:16) {
  _error: Error
      at new ExtendableError (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/extendable-error/bld/index.js:23:24)
      at new ValidationError (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/errors/dist/errors.cjs.dev.js:16:1)
      at parse (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/config/dist/config.cjs.dev.js:206:11)
      at Object.read (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/config/dist/config.cjs.dev.js:87:10)
      at async run$1 (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/cli/dist/cli.cjs.dev.js:1096:16)
}

google-oss-bot · 2021-08-20T23:32:48Z

Binary Size Report

Affected SDKs

`@firebase/firestore`

Type	Base (`b03423b`)	Head (`d8dcd58`)	Diff
browser	225 kB	225 kB	-87 B (-0.0%)
main	512 kB	512 kB	+192 B (+0.0%)
module	225 kB	225 kB	-87 B (-0.0%)
react-native	225 kB	225 kB	-87 B (-0.0%)

`@firebase/firestore-lite`

Type	Base (`b03423b`)	Head (`d8dcd58`)	Diff
browser	72.9 kB	71.7 kB	-1.24 kB (-1.7%)
main	149 kB	147 kB	-1.99 kB (-1.3%)
module	72.9 kB	71.7 kB	-1.24 kB (-1.7%)
react-native	73.1 kB	71.9 kB	-1.24 kB (-1.7%)

firebase

Type Base (b03423b) Head (d8dcd58) Diff

firebase-firestore.js 63.8 kB 63.6 kB -227 B (-0.4%)

firebase.js 628 kB 628 kB -227 B (-0.0%)

Test Logs

Base (b03423be): https://github.com/firebase/firebase-js-sdk/actions/runs/1152269599
Head (d8dcd588): https://github.com/firebase/firebase-js-sdk/actions/runs/1152637262

google-oss-bot · 2021-08-20T23:37:02Z

Size Analysis Report

Affected Products

No changes between base commit (b03423b) and head commit (d8dcd58).

Test Logs

* compile firestore * update typings path * compile firestore compat * lint compat * make test work * get most tests work * build * remove special paths * update firestore-compat pkg json * fix merge issues * Simplify bundles * Prettier * Fix Bundle compile * Fix build * address comments * console build * Fix all tests * Prettier * fix merge issues * fix typo * update paths * app-exp * fix lint * correct path * fix * fix compat lint * fix firestore integration * fix workflow * update dep * Always block on Auth (#5340) * Always block on Auth * Don't block on token if already recevied * fix lint * build firestore * remove memory only tests * fix firebase integration tests * enable more build and tests * add firestore-compat to firebase dep * fix auth compat class * enable auth test * auth package doc * Update API reports Co-authored-by: Sebastian Schmidt <[email protected]> Co-authored-by: Feiyang1 <[email protected]>

* Split storage and storage-compat (#5271) * separate storage-compat from storage * commit * fix tests * wat? * build storage-compat * save * fixing some compat tests * format * update import path * format * get compat tests to work * format * update package json * cleanup * format * address comments * Update packages/storage-compat/test/unit/service.test.ts Co-authored-by: Christina Holland <[email protected]> * add missing dev dep * Update packages/storage-compat/package.json * Update packages/storage-compat/package.json * Update deps after v8 release * update compat version * Split database and database-compat (#5276) * compile database * pass database tests * compile and test database-compat * pass all tests * prettier * cleanup * fix lint * address comments * what is going on with ci * use correct case in import path * uppercase * rename * fix component name * Repo refactoring for v9 (#5325) * rename folders * rename folders * migrate app and app-compat * migrate installations and analytics * migrate app check * migrate auth * migrate functions * migrate messaging * migrate performance * migrate remoteconfig * remove v8 code * update versions * migrate firebase * fix merge issues * save * fix firebase builds * update changeset config * update build scripts * update release script * fix functions typings * remove redundant typings * update path * treat external dependencies correctly * fix lint * remove firestore-compat references * fix build issues * update build scripts * update pkg json * fix test * fix some tests * fix some tests * fix integration tests * fixes * fix dep * update ci tests * resolve todos * remove exp references * docgen build * export FirebaseError (#5349) * firebase packaging update (#5348) * Fei v9 main firestore (#5319) * compile firestore * update typings path * compile firestore compat * lint compat * make test work * get most tests work * build * remove special paths * update firestore-compat pkg json * fix merge issues * Simplify bundles * Prettier * Fix Bundle compile * Fix build * address comments * console build * Fix all tests * Prettier * fix merge issues * fix typo * update paths * app-exp * fix lint * correct path * fix * fix compat lint * fix firestore integration * fix workflow * update dep * Always block on Auth (#5340) * Always block on Auth * Don't block on token if already recevied * fix lint * build firestore * remove memory only tests * fix firebase integration tests * enable more build and tests * add firestore-compat to firebase dep * fix auth compat class * enable auth test * auth package doc * Update API reports Co-authored-by: Sebastian Schmidt <[email protected]> Co-authored-by: Feiyang1 <[email protected]> * rebasing * Create registerMessagingCompat.ts * Add changeset for v9 (#5350) * add changeset * publish messaging interop * add firestore bumps * update changeset * Revert "Create registerMessagingCompat.ts" This reverts commit 0b95a51. * Revert "rebasing" This reverts commit a8bf697. * Update index.d.ts (#5355) * Fix Context Check in `Messaging-Compat` (#5353) * Add Rules Unit Testing v2 skeleton for v9 release (#5352) * Reset package for next major version. * Switch emulator script to node-fetch. * Migrate the other request call to fetch. * Update packages/rules-unit-testing/package.json Co-authored-by: Feiyang <[email protected]> * Create stale-ducks-live.md * Revert version change. Co-authored-by: Feiyang <[email protected]> * fix import path (#5356) * Add new types and function stubs for RUT vNext. (#5316) * Add new types and function stubs. * Fix types for testEnv.emulators. * Add util functions. * Add withFunctionTriggersDisabled overloads. * Improve typing for EmulatorConfig. * Fix tests. * Rename test_environment.ts to initialize.ts. * Add a dummy test to make CI pass. * Implement emulators discovery in RUTv2. (#5334) * Add new types and function stubs. * Fix types for testEnv.emulators. * Add util functions. * Add withFunctionTriggersDisabled overloads. * Improve typing for EmulatorConfig. * Fix tests. * Rename test_environment.ts to initialize.ts. * Add a dummy test to make CI pass. * Implement emulators discovery. * Use URL object from global. * Fix unreachable error code. * Implement most of RUTv2 features. (#5343) * Implement most of RUTv2 features. * Switch to compat instances. * Remove legacy code. * Use public typings for release (#5358) * use public typings for storage * use public typings for database * Implement rest of RUTv2 features. (#5360) * Implement loading rules and withFunctionTriggersDisabled. * Implement clearFirestore and storage. * Add missing await. * Add default bucketUrl. * Use alternative method to clear bucket. * Use default param (review feedback). * Storage typing updates (#5359) * rename to StorageError * more type safety * Update API reports * update api report Co-authored-by: Feiyang1 <[email protected]> * correct component name * fix installtions-compat typing * remove rules-unit-testing from ignore list * reenable things * support mjs files * correct matching pattern * transform only @firebase/util * use public types for database doc * transform all but compat packages Co-authored-by: Sebastian Schmidt <[email protected]> Co-authored-by: Feiyang1 <[email protected]> Co-authored-by: kai <[email protected]> Co-authored-by: Yuchen Shi <[email protected]> Co-authored-by: Kai Wu <[email protected]>

schmidt-sebastian requested review from Feiyang1, hiranya911 and hsubox76 as code owners August 20, 2021 23:09

schmidt-sebastian changed the title ~~Mrschmidt/authfix merge~~ Always block on Auth Aug 20, 2021

Always block on Auth

cd668c3

schmidt-sebastian force-pushed the mrschmidt/authfix-merge branch from d3cb8f4 to cd668c3 Compare August 20, 2021 23:20

Don't block on token if already recevied

4a53235

Feiyang1 approved these changes Aug 21, 2021

View reviewed changes

Feiyang1 merged commit aa5b344 into fei-v9-main-firestore Aug 21, 2021

Feiyang1 deleted the mrschmidt/authfix-merge branch August 21, 2021 05:12

schmidt-sebastian restored the mrschmidt/authfix-merge branch August 24, 2021 19:59

firebase locked and limited conversation to collaborators Sep 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Always block on Auth #5340

Always block on Auth #5340

schmidt-sebastian commented Aug 20, 2021 •

edited

Loading

changeset-bot bot commented Aug 20, 2021 •

edited

Loading

github-actions bot commented Aug 20, 2021

google-oss-bot commented Aug 20, 2021 •

edited

Loading

`@firebase/firestore`

`@firebase/firestore-lite`

`firebase`

google-oss-bot commented Aug 20, 2021 •

edited

Loading

Affected Products

Test Logs

Always block on Auth #5340

Always block on Auth #5340

Conversation

schmidt-sebastian commented Aug 20, 2021 • edited Loading

changeset-bot bot commented Aug 20, 2021 • edited Loading

⚠️ No Changeset found

github-actions bot commented Aug 20, 2021

Changeset File Check ⚠️

google-oss-bot commented Aug 20, 2021 • edited Loading

Binary Size Report

Affected SDKs

@firebase/firestore

@firebase/firestore-lite

firebase

Test Logs

google-oss-bot commented Aug 20, 2021 • edited Loading

Size Analysis Report

Affected Products

Test Logs

schmidt-sebastian commented Aug 20, 2021 •

edited

Loading

changeset-bot bot commented Aug 20, 2021 •

edited

Loading

google-oss-bot commented Aug 20, 2021 •

edited

Loading

`@firebase/firestore`

`@firebase/firestore-lite`

`firebase`

google-oss-bot commented Aug 20, 2021 •

edited

Loading