Allow type T in WithFieldValue<T> #5675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebrianchen
requested review from
egilmorez,
Feiyang1,
hiranya911 and
hsubox76
as code owners
🦋 Changeset detectedLatest commit: f2acddc The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Analysis ReportAffected Products
|
| class ObjectWrapper<T> { | ||
| withFieldValueT(value: WithFieldValue<T>): void { | ||
| // eslint-disable-next-line no-console | ||
| console.log(value); |
There was a problem hiding this comment.
Do we need to log here?
| ? T | ||
| : T extends {} | ||
| ? { [K in keyof T]: WithFieldValue<T[K]> | FieldValue } | ||
| : Partial<T>); |
There was a problem hiding this comment.
Unrelated to this PR, but why do we allow Partial here? Does that mean a user can omit properties as long as they are nested?
There was a problem hiding this comment.
This should technically be never. Fixed.
Binary Size ReportAffected SDKs
Test Logs |
schmidt-sebastian
approved these changes
Nov 2, 2021
Feiyang1
suggested changes
Nov 2, 2021
egilmorez
approved these changes
Nov 2, 2021
.changeset/short-mice-itch.md
Outdated
| '@firebase/firestore': minor | ||
| --- | ||
|
|
||
| Expanded `Firestore.WithFieldValue<T>` to include `T`. This allows developers to delegate `WithFieldValue<T>` inside a wrappers of type `T` to avoid exposing Firebase types beyond Firebase-specific logic. |
There was a problem hiding this comment.
I think "a wrappers" should just be "wrappers"
Co-authored-by: Feiyang <[email protected]>
…dk into bc/withfieldvalue
Feiyang1
approved these changes
Nov 3, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5661. Thanks @gustavohenke for proactively bringing up the fix!
This change allows developers to pass an object of type
TintoWithFieldValue<T>.