Exclude NodeJS.ReadableStream from compat overloads #5743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsubox76
requested review from
Feiyang1,
hiranya911 and
schmidt-sebastian
as code owners
Size Analysis Report |
Feiyang1
reviewed
Nov 18, 2021
| @@ -236,7 +236,7 @@ export function getStreamInternal( | |||
|
|
|||
| ref.storage | |||
| .makeRequestWithTokens(requestInfo, newStreamConnection) | |||
| .then(stream => stream.pipe(result)) | |||
| .then(stream => (stream as NodeJS.ReadableStream).pipe(result)) | |||
There was a problem hiding this comment.
Changes in this file seem unrelated?
There was a problem hiding this comment.
This is "also fix some type errors in storage", storage was spitting out some errors on build that I was concerned about.
🦋 Changeset detectedLatest commit: 771a652 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add NodeJS.ReadableStream to excluded builtin types in the compat overloads script. Maybe there's a more robust way to address this, or can look into it later.
Also fix some type errors in storage.