-
Notifications
You must be signed in to change notification settings - Fork 928
[Auth] Add gmpid header #5799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Auth] Add gmpid header #5799
Conversation
🦋 Changeset detectedLatest commit: 75a6871 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs |
Size Analysis ReportAffected Products
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Is there an internal bug and/or issue associated with this change?
b/205577736 |
Thanks! |
async _getAdditionalHeaders(): Promise<Record<string, string>> { | ||
// Additional headers on every request | ||
const headers: Record<string, string> = { | ||
[HttpHeader.X_CLIENT_VERSION]: this.clientVersion, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this.clientVersion
always non-empty and non-null? If unsure, please add a check. Empty header values may break emulators)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just moved code (the prior revision also always sends it). It's also always populated
No description provided.