Skip to content

Fix isWindowSupported() check #5957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Fix isWindowSupported() check #5957

merged 2 commits into from
Feb 1, 2022

Conversation

hsubox76
Copy link
Contributor

Wrap validateIndexedDBOpenable() in a try/catch. Add a comment to the equivalent function in messaging-compat to remind us of why we can't add this check there.

Fixes #5868

@hsubox76 hsubox76 requested a review from zwu52 as a code owner January 31, 2022 21:40
@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2022

🦋 Changeset detected

Latest commit: 360b33c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/messaging Patch
firebase Patch
@firebase/messaging-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 31, 2022

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (aaeab08)Merge (afd4772)Diff
    browser229 kB229 kB+44 B (+0.0%)
    esm5286 kB286 kB+48 B (+0.0%)
    main456 kB456 kB+74 B (+0.0%)
    module229 kB229 kB+44 B (+0.0%)
    react-native229 kB229 kB+44 B (+0.0%)
  • @firebase/firestore-lite

    TypeBase (aaeab08)Merge (afd4772)Diff
    browser72.7 kB72.7 kB+35 B (+0.0%)
    esm586.0 kB86.0 kB+40 B (+0.0%)
    main125 kB125 kB+44 B (+0.0%)
    module72.7 kB72.7 kB+35 B (+0.0%)
    react-native72.9 kB72.9 kB+35 B (+0.0%)
  • @firebase/messaging

    TypeBase (aaeab08)Merge (afd4772)Diff
    browser20.8 kB20.8 kB+25 B (+0.1%)
    esm526.1 kB26.1 kB+22 B (+0.1%)
    main26.8 kB26.8 kB+22 B (+0.1%)
    module20.8 kB20.8 kB+25 B (+0.1%)
  • bundle

    13 size changes

    TypeBase (aaeab08)Merge (afd4772)Diff
    firestore (Persistence)230 kB230 kB+49 B (+0.0%)
    firestore (Query Cursors)189 kB189 kB+49 B (+0.0%)
    firestore (Query)190 kB190 kB+49 B (+0.0%)
    firestore (Read data once)179 kB179 kB+49 B (+0.0%)
    firestore (Realtime updates)181 kB181 kB+49 B (+0.0%)
    firestore (Transaction)163 kB163 kB+36 B (+0.0%)
    firestore (Write data)163 kB163 kB+36 B (+0.0%)
    firestore-lite (Query Cursors)56.6 kB56.6 kB+36 B (+0.1%)
    firestore-lite (Query)59.6 kB59.7 kB+36 B (+0.1%)
    firestore-lite (Read data once)44.1 kB44.2 kB+36 B (+0.1%)
    firestore-lite (Transaction)61.5 kB61.5 kB+36 B (+0.1%)
    firestore-lite (Write data)47.0 kB47.0 kB+36 B (+0.1%)
    messaging (send + receive)37.8 kB37.8 kB+25 B (+0.1%)

  • firebase

    TypeBase (aaeab08)Merge (afd4772)Diff
    firebase-compat.js754 kB754 kB+49 B (+0.0%)
    firebase-firestore-compat.js281 kB281 kB+49 B (+0.0%)
    firebase-firestore-lite.js249 kB249 kB+111 B (+0.0%)
    firebase-firestore.js775 kB775 kB+129 B (+0.0%)
    firebase-messaging.js101 kB101 kB+200 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/61tMVJnRpQ.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 31, 2022

Size Analysis Report 1

This report is too large (649,221 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/SrFCZkyxdU.html

@hsubox76 hsubox76 merged commit 0a04a1c into master Feb 1, 2022
@hsubox76 hsubox76 deleted the ch-messaging-idb branch February 1, 2022 17:56
@google-oss-bot google-oss-bot mentioned this pull request Feb 1, 2022
@firebase firebase locked and limited conversation to collaborators Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Messaging in Firefox private mode (IndexedDb)
3 participants