Skip to content

Fill Currently MissingFcmOptions.link #6327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 3, 2022
Merged

Fill Currently MissingFcmOptions.link #6327

merged 7 commits into from
Jun 3, 2022

Conversation

zwu52
Copy link
Member

@zwu52 zwu52 commented Jun 2, 2022

b/232072111

Should resolve #6207 & #5824

@changeset-bot
Copy link

changeset-bot bot commented Jun 2, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: b7ec7bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/messaging Patch
firebase Patch
@firebase/messaging-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@zwu52 zwu52 requested a review from hsubox76 June 2, 2022 19:30
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 2, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/messaging

    TypeBase (f84cacd)Merge (b59e53e)Diff
    browser20.8 kB21.1 kB+289 B (+1.4%)
    esm526.2 kB26.5 kB+289 B (+1.1%)
    main26.9 kB27.2 kB+289 B (+1.1%)
    module20.8 kB21.1 kB+289 B (+1.4%)

  • @firebase/messaging-sw

    TypeBase (f84cacd)Merge (b59e53e)Diff
    main29.6 kB29.9 kB+289 B (+1.0%)
    module22.9 kB23.2 kB+289 B (+1.3%)

  • @firebase/storage

    TypeBase (f84cacd)Merge (b59e53e)Diff
    main57.3 kB57.4 kB+84 B (+0.1%)

  • bundle

    TypeBase (f84cacd)Merge (b59e53e)Diff
    messaging (send + receive)44.7 kB45.0 kB+227 B (+0.5%)

  • firebase

    TypeBase (f84cacd)Merge (b59e53e)Diff
    firebase-compat.js788 kB788 kB+420 B (+0.1%)
    firebase-messaging-compat.js37.5 kB37.9 kB+420 B (+1.1%)
    firebase-messaging-sw.js107 kB107 kB+467 B (+0.4%)
    firebase-messaging.js105 kB106 kB+467 B (+0.4%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Kmr4oqPaG4.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 2, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/messaging

    • deleteToken

      Size

      TypeBase (f84cacd)Merge (b59e53e)Diff
      size12.3 kB12.5 kB+227 B (+1.8%)
      size-with-ext-deps37.8 kB38.1 kB+227 B (+0.6%)

    • getMessaging

      Size

      TypeBase (f84cacd)Merge (b59e53e)Diff
      size12.8 kB13.0 kB+227 B (+1.8%)
      size-with-ext-deps38.4 kB38.6 kB+227 B (+0.6%)

    • getToken

      Size

      TypeBase (f84cacd)Merge (b59e53e)Diff
      size12.2 kB12.4 kB+227 B (+1.9%)
      size-with-ext-deps37.7 kB38.0 kB+227 B (+0.6%)

    • isSupported

      Size

      TypeBase (f84cacd)Merge (b59e53e)Diff
      size12.5 kB12.8 kB+227 B (+1.8%)
      size-with-ext-deps38.0 kB38.3 kB+227 B (+0.6%)

    • onMessage

      Size

      TypeBase (f84cacd)Merge (b59e53e)Diff
      size12.3 kB12.6 kB+227 B (+1.8%)
      size-with-ext-deps37.9 kB38.1 kB+227 B (+0.6%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8oAYVPN2EE.html

@zwu52 zwu52 requested a review from egilmorez as a code owner June 2, 2022 21:30
egilmorez
egilmorez approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

iiuc, this does not have direct doc impact, except maybe in release notes.

@zwu52 zwu52 merged commit c66d59c into master Jun 3, 2022
@zwu52 zwu52 deleted the fix_fcm_options_click_action branch June 3, 2022 17:10
@google-oss-bot google-oss-bot mentioned this pull request Jun 9, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@egilmorez egilmorez egilmorez approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to receive fcmOptions field on default firebase handlers
4 participants
@zwu52 @google-oss-bot @egilmorez @hsubox76