Skip to content

Fix Node ESM bundle to build from Node entry point. #6345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Jun 8, 2022

The Storage Node ESM bundle was incorrectly building from entry point index.ts instead of index.node.ts

Ran a build and the index.node.esm.js compiled bundle no longer contains "getStream() is only supported by NodeJS builds" error string.

Fixes #6343.

@changeset-bot
Copy link

changeset-bot bot commented Jun 8, 2022

🦋 Changeset detected

Latest commit: c1366a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/storage Patch
firebase Patch
@firebase/storage-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hsubox76 hsubox76 requested a review from dwyfrequency June 8, 2022 20:57
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimmetrius
Copy link

wohoo! ESM bundle fixed 🚀

@hsubox76 hsubox76 merged commit d6338f0 into master Jun 8, 2022
@hsubox76 hsubox76 deleted the ch-storage-node branch June 8, 2022 23:00
@google-oss-bot google-oss-bot mentioned this pull request Jun 9, 2022
@firebase firebase locked and limited conversation to collaborators Jul 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: getStream() is only supported by NodeJS builds
5 participants