Add types for Service Worker Controller #673
Conversation
Updates TypeScript to 2.8.1, which has much better WebWorker and Notification typings
|
|
||
| // Not the whole interface, just the parts we're currently using. | ||
| // If TS claims that something does not exist on this, feel free to add it. | ||
| interface ServiceWorkerGlobalScope { |
There was a problem hiding this comment.
Does this not already exist as a TSLib?
There was a problem hiding this comment.
It exists (as a type definition file), but it can't be used simultaneously with DOM.
microsoft/TypeScript#20595
microsoft/TypeScript#14687
So I took some parts of it that we need (and doesn't conflict with DOM) and put them here.
There was a problem hiding this comment.
Fair enough. Let's just add a link to the actual file and keep an eye on if we can undo this in the future.
| const FCM_MSG = 'FCM_MSG'; | ||
|
|
||
| export type BgMessageHandler = (input: any) => Promise<any>; | ||
| export type BgMessageHandler = (input: Payload) => void; |
There was a problem hiding this comment.
You could be expecting a promise to be returned here so you can pass the promise to event.waitUntil(). Otherwise the service worker could be terminated before the developers work has finished.
There was a problem hiding this comment.
That's a good point, thanks!
|
Created #676 for dependency upgrades. |
mmermerkaya
requested review from
mikelehen,
schmidt-sebastian and
wilhuff
as code owners
This reverts commit 306f97c. Forgot to run `yarn` after switching branches, which made the push hook run the updated version of prettier, which created this commit.
|
They should pass once #676 is merged. |
Also updates TypeScript to 2.8.1, which has much better WebWorker and Notification typings, which allowed me to remove some more "any" casts.