Skip to content

setRules endpoint for Storage Emulator #3332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 5, 2021

Conversation

samtstern
Copy link
Contributor

@samtstern samtstern commented May 4, 2021

Description

Needed to implement some version of:
firebase/firebase-js-sdk#4863

Scenarios Tested

Good Rules

Screen Shot 2021-05-04 at 6 25 10 PM

Bad Rules

Screen Shot 2021-05-04 at 6 23 57 PM

Bad Requests

Screen Shot 2021-05-04 at 6 11 58 PM
Screen Shot 2021-05-04 at 6 11 26 PM

Sample Commands

N/A

@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label May 4, 2021
@abeisgoat
Copy link
Contributor

Do the other emulators also return a non-json response? I feel like making that machine readable would be ideal

@samtstern
Copy link
Contributor Author

Do the other emulators also return a non-json response? I feel like making that machine readable would be ideal

I can change this to a simple JSON object like { "message": ... } but I hesitate to include the whole issues payload since right now there is no code which will actually consume it and therefore it's just making an API promise earlier than we need to.

@samtstern samtstern merged commit 17bad02 into master May 5, 2021
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this pull request Dec 14, 2021
@bkendall bkendall deleted the ss-storage-setrules-endpoint branch March 18, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants