Skip to content

Fix sendStatus/status typo in Storage emulator #3338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 6, 2021
Merged

Fix sendStatus/status typo in Storage emulator #3338

merged 4 commits into from
May 6, 2021

Conversation

samtstern
Copy link
Contributor

Description

Successfully setting Storage rules causes this error:

(node:90535) UnhandledPromiseRejectionWarning: Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
    at ServerResponse.setHeader (_http_outgoing.js:530:11)
    at ServerResponse.header (/Users/samstern/Projects/firebase-js-sdk/node_modules/express/lib/response.js:771:10)
    at ServerResponse.send (/Users/samstern/Projects/firebase-js-sdk/node_modules/express/lib/response.js:170:12)
    at ServerResponse.json (/Users/samstern/Projects/firebase-js-sdk/node_modules/express/lib/response.js:267:15)
    at /Users/samstern/Projects/firebase-js-sdk/packages/rules-unit-testing/node_modules/firebase-tools/lib/emulator/storage/server.js:73:29
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

Scenarios Tested

Tested manually with rules-unit-testing PR.

Sample Commands

N/A

@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label May 6, 2021
@samtstern samtstern requested a review from abeisgoat May 6, 2021 09:48
@samtstern samtstern mentioned this pull request May 6, 2021
Merged
4 tasks
@yuchenshi yuchenshi merged commit 34d4001 into master May 6, 2021
@yuchenshi yuchenshi deleted the ss-storage-setrules-sendstatus branch May 6, 2021 16:24
@yuchenshi yuchenshi mentioned this pull request May 6, 2021
Merged
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this pull request Dec 14, 2021
@samtstern @yuchenshi @devpeerapong
Fix sendStatus/status typo in Storage emulator (firebase#3338)
3bda914 
Co-authored-by: Yuchen Shi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joehan joehan joehan approved these changes

@yuchenshi yuchenshi yuchenshi approved these changes

@abeisgoat abeisgoat Awaiting requested review from abeisgoat

Assignees

@abeisgoat abeisgoat

Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samtstern @joehan @yuchenshi @abeisgoat