Modify multi-tenancy impacted endpoints according to admin integ tests #3818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 12, 2021
sam-gc
approved these changes
Oct 12, 2021
yuchenshi
approved these changes
Oct 12, 2021
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update endpoints impacted by multi-tenancy change so they pass tests existing in admin SDK
Corresponding admin SDK integration test changes: firebase/firebase-admin-node#1453
Corresponding internal bug: b/192387245
Scenarios Tested
npm testpasses in auth emulatornpm run buildin auth emulator, followed bynode /Users/lisajian/dev/firebase-tools/lib/bin/firebase emulators:exec --project fake-project-id --only auth,database,firestore 'npx mocha \"test/integration/auth.spec.ts\" --slow 5000 --timeout 20000 --require ts-node/register --testMultiTenancy'passes in firebase-admin-node SDKSample Commands
N/A